Fix javadoc and parameter name and add warning to FHIRUtil.getRandomKey #1394
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
punktilious
reviewed
Jul 31, 2020
| keyGen.init(256); | ||
| return Base64.getEncoder().encodeToString(keyGen.generateKey().getEncoded()); | ||
| } catch (NoSuchAlgorithmException e) { | ||
| log.warning("Algorithm '" + algorithm + "' is not supported; using SecureRandom instead"); | ||
| byte[] buffer = new byte[32]; | ||
| RANDOM.setSeed(System.currentTimeMillis()); |
There was a problem hiding this comment.
I know it's not related to this change, but why are we seeding here? Potential OWASP because currentTimeMillis isn't sufficiently random.
There was a problem hiding this comment.
I was wondering the same thing, which is why i added the warning...i'm not even sure it should fallback to SecureRandom
There was a problem hiding this comment.
I don't think this should be in FHIRUtil -- it should go into bulkdata, and be hidden away.
Signed-off-by: Lee Surprenant <lmsurpre@us.ibm.com>
Signed-off-by: Lee Surprenant <lmsurpre@us.ibm.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Lee Surprenant lmsurpre@us.ibm.com