Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Misleading completed bundle request message #3107

Closed
prb112 opened this issue Dec 10, 2021 · 1 comment
Closed

Misleading completed bundle request message #3107

prb112 opened this issue Dec 10, 2021 · 1 comment
Assignees
Labels
bug Something isn't working technical debt

Comments

@prb112
Copy link
Contributor

prb112 commented Dec 10, 2021

Describe the bug
A clear and concise description of what the bug is.

The message shows the running time across the bundle, not the Bundle.Entry

[INFO    ] Completed bundle request took:[2.415 secs]: entryIndex:[39] correlationId:[5ad0421b-f0bd-49f9-9e23-ded3f62f997f] method:[PUT] uri:[ValueSet/2.16.840.1.113883.3.117.1.7.1.219] status:[201]
[INFO    ] Completed bundle request took:[2.435 secs]: entryIndex:[40] correlationId:[5ad0421b-f0bd-49f9-9e23-ded3f62f997f] method:[PUT] uri:[ValueSet/2.16.840.1.113883.3.117.1.7.1.222] status:[201]
[INFO    ] Completed bundle request took:[2.454 secs]: entryIndex:[41] correlationId:[5ad0421b-f0bd-49f9-9e23-ded3f62f997f] method:[PUT] uri:[ValueSet/2.16.840.1.113883.3.117.1.7.1.223] status:[201]
[INFO    ] Completed bundle request took:[2.475 secs]: entryIndex:[42] correlationId:[5ad0421b-f0bd-49f9-9e23-ded3f62f997f] method:[PUT] uri:[ValueSet/2.16.840.1.113883.3.117.1.7.1.230] status:[201]
[INFO    ] Completed bundle request took:[2.497 secs]: entryIndex:[43] correlationId:[5ad0421b-f0bd-49f9-9e23-ded3f62f997f] method:[PUT] uri:[ValueSet/2.16.840.1.113883.3.117.1.7.1.232] status:[201]
[INFO    ] Completed bundle request took:[2.53 secs]: entryIndex:[44] correlationId:[5ad0421b-f0bd-49f9-9e23-ded3f62f997f] method:[PUT] uri:[ValueSet/2.16.840.1.113883.3.117.1.7.1.247] status:[201]
[INFO    ] Completed bundle request took:[2.867 secs]: entryIndex:[45] correlationId:[5ad0421b-f0bd-49f9-9e23-ded3f62f997f] method:[PUT] uri:[ValueSet/2.16.840.1.113883.3.117.1.7.1.255] status:[201]
[INFO    ] Completed bundle request took:[2.893 secs]: entryIndex:[46] correlationId:[5ad0421b-f0bd-49f9-9e23-ded3f62f997f] method:[PUT] uri:[ValueSet/2.16.840.1.113883.3.117.1.7.1.256] status:[201]v

Due to FHIRRestInteractionVisitorBase.java using:

private void logBundledRequestCompletedMsg(String requestDescription, long initialTime, String httpStatus) {
        StringBuffer msg = new StringBuffer();
        double elapsedSecs = (System.currentTimeMillis() - initialTime) / 1000.0;

        msg.append("Completed bundle request took:[");
        msg.append(elapsedSecs);
        msg.append(" secs]: ");
        msg.append(requestDescription);
        msg.append(" status:[" + httpStatus + "]");
        log.info(msg.toString());
    }

Environment
Which version of IBM FHIR Server?

To Reproduce
Steps to reproduce the behavior:

  1. Go to '...'
  2. Click on '....'
  3. Scroll down to '....'
  4. See error

Expected behavior
A clear and concise description of what you expected to happen.

Additional context
Add any other context about the problem here.

@prb112 prb112 added bug Something isn't working technical debt labels Dec 10, 2021
@prb112 prb112 self-assigned this Dec 10, 2021
@prb112
Copy link
Contributor Author

prb112 commented Dec 20, 2021

Looks great...

[INFO    ] Completed request[0.041924812 secs]: tenantId:[default] dsId:[default] user:[fhiruser] method:[GET] uri:[https://localhost:9443/fhir-server/api/v4/Patient?family=e0ffca67-9c80-4d57-bce8-72076a7bca84] status:[200]

@prb112 prb112 closed this as completed Dec 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working technical debt
Projects
None yet
Development

No branches or pull requests

2 participants