-
Notifications
You must be signed in to change notification settings - Fork 157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Warn and skip update-schema when deployed version > new version #3032
Comments
With this issue we may also want to address the drop-schema (incorrect version used issue) that an error is issued if you try to drop a older schema with a newer tool, or vice versa. Maybe even tell them what version of the tool needs to be used. |
A related scenario I thought of:
Currently, there is no way to force it to do its thing when the schema version matches the expected schema version. For this use case, and maybe also for the case described in "Additional context" above, I think it would be nice to add a |
For the drop schema, I'm thinking we want to make it dictionary-driven so that it doesn't matter which version you have. |
The new |
Signed-off-by: Robin Arnold <robin.arnold@ibm.com>
Any issues with multi Tenant on different versions? |
Signed-off-by: Robin Arnold <robin.arnold@ibm.com>
Signed-off-by: Robin Arnold <robin.arnold@ibm.com>
…3200) * issue #3032 only update when current schema is behind code version Signed-off-by: Robin Arnold <robin.arnold@ibm.com> * issue #3032 return error status when force arg given but does not apply Signed-off-by: Robin Arnold <robin.arnold@ibm.com> * issue #3032 added force option to menu help Signed-off-by: Robin Arnold <robin.arnold@ibm.com>
to QA:
|
the update-schema does not do any updates when the schema version > attempted update schema version. Closing issue.
|
Is your feature request related to a problem? Please describe.
In https://github.com/IBM/FHIR/pull/2880/files#diff-b4577e1635a5c980b9e41f30be0c6abcbf3fe5e6915b118fd319963bdac70a78R440 we added a check so that we skip
--update-schema
when the deployed version is already up-to-date.However, this got implemented in SchemaVersionsManager as an
==
check: https://github.com/IBM/FHIR/pull/2880/files#diff-125e38fd75a71288d1716b5c3c920f85cdca913358ce3ec5b236973890ccddfcR101This means that the updateSchema code will run if the currently-deployed schema version is greater than the new version being applied.
And because we always updated the stored procs (irregardless of version), this can have unintended consequences.
Describe the solution you'd like
If the currently-deployed schema version is greater than the one being "updated to", then log a warning and skip the work.
Most importantly, do NOT update (i.e. downgrade) the stored procs and do NOT update the whole-schema version.
Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.
Acceptance Criteria
AND [another precondition]
WHEN [test step]
AND [test step]
THEN [verification step]
AND [verification step]
Additional context
In one variation of this issue, you can end up with back-level stored proc definitions that don't update when you run
--update-schema
with a newer version of the tool.If you run into this scenario, the fix is to execute the
--update-proc
(and not--update-schema
) action of the 4.10 version of the tool.The text was updated successfully, but these errors were encountered: