Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

suggest setting CapabilityStatement.rest.resource.versioning to versioned-update #2903

Closed
kmbarton423 opened this issue Oct 26, 2021 · 4 comments
Assignees
Labels
enhancement New feature or request

Comments

@kmbarton423
Copy link
Contributor

Found that the latest release of IBM FHIR Server CapabilityStatement does not provide information for CapabilityStatement.rest.resource.versioning. Though this element is not required, a setting of "versioned-update" would indicate full versioning support.

@kmbarton423 kmbarton423 added the enhancement New feature or request label Oct 26, 2021
@lmsurpre
Copy link
Member

I think maybe versioned would be more appropriate given the spec's definition of versioned-update from https://www.hl7.org/fhir/valueset-versioning-policy.html:

VersionId must be correct for updates (server) or will be specified (If-match header) for updates (client)

I don't think we check the Resource.meta.versionId during an update....we just overwrite that with the proper value.

However, we do support the "If-Match" header, so I'm not totally sure.

@lmsurpre lmsurpre added this to the Sprint 2021-15 milestone Oct 26, 2021
@lmsurpre
Copy link
Member

OK, I found that https://www.hl7.org/fhir/http.html#versions has a slightly expanded definition for versioned-update:

Versioning and meta.version is supported, and version aware updates are used - Version ID must be correct for updates (server) or will be specified (If-match header) for updates (client)

The first part of that sounds like what we have: "Versioning and meta.version is supported, and version aware updates are used". My concern is with the next bit (shared by the valueset definiton): "VersionId must be correct for updates"...we might need to ask for clarificatoin on chat.fhir.org

@lmsurpre lmsurpre self-assigned this Oct 26, 2021
lmsurpre added a commit that referenced this issue Oct 26, 2021
…atement

Signed-off-by: Lee Surprenant <lmsurpre@us.ibm.com>
@lmsurpre
Copy link
Member

lmsurpre added a commit that referenced this issue Oct 28, 2021
…atement (#2906)

* issue #2903 - add versioning element to all resources in CapabilityStatement

Signed-off-by: Lee Surprenant <lmsurpre@us.ibm.com>

* change from vesioned to versioned-update

Signed-off-by: Lee Surprenant <lmsurpre@us.ibm.com>
@lmsurpre
Copy link
Member

this was done based on some new failures on the touchstone basic suite. after deploying the updates, that suite is now passing again with 100% conformance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants