Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

_pretty is handled like an invalid search parameter #1052

Closed
lmsurpre opened this issue May 8, 2020 · 0 comments · Fixed by #1058
Closed

_pretty is handled like an invalid search parameter #1052

lmsurpre opened this issue May 8, 2020 · 0 comments · Fixed by #1058
Assignees
@lmsurpre
Labels
bug Something isn't working
Milestone
Sprint 12

Comments

@lmsurpre
Copy link
Member

lmsurpre commented May 8, 2020

Describe the bug
com.ibm.fhir.search.exception.FHIRSearchException: Search parameter ‘_pretty’ for resource type ‘Patient’ was not found. [probeId=c0-a8-1-e3-d0356d59-6273-421a-ab8d-00f34bcae48d]

To Reproduce
Steps to reproduce the behavior:

  1. start server
  2. run PrettyServerFormatTest from fhir-server-test

Expected behavior
Pretty should be interpretted as a return parameter that just controls the format of the response

Additional context
From https://www.hl7.org/fhir/R4/search.html

In addition, there is a special search parameters _query and _filter that allow for an alternative method of searching, and the parameters _format and _pretty defined for all interactions.
@lmsurpre lmsurpre added the bug Something isn't working label May 8, 2020
@lmsurpre lmsurpre self-assigned this May 8, 2020
@lmsurpre lmsurpre added this to the Sprint 12 milestone May 8, 2020
lmsurpre added a commit that referenced this issue May 8, 2020
@lmsurpre
issue #1052 - ignore non-return parameter "general parameters" in search
6de4860 
move "general parameter" parameter names to FHIRConstants in `fhir-core`
and update SearchUtil

Signed-off-by: Lee Surprenant <lmsurpre@us.ibm.com>
lmsurpre added a commit that referenced this issue May 8, 2020
@lmsurpre
issue #1052 - ignore non-return parameter "general parameters" in search
b035a13 
move "general parameter" parameter names to FHIRConstants in `fhir-core`
and update SearchUtil

Signed-off-by: Lee Surprenant <lmsurpre@us.ibm.com>
@lmsurpre lmsurpre mentioned this issue May 8, 2020
Merged
prb112 added a commit that referenced this issue May 8, 2020
@prb112
Merge pull request #1058 from IBM/lee-master
efa723f 
issue #1052 - ignore non-return parameter "general parameters" in search
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lmsurpre lmsurpre

Labels
bug Something isn't working
Projects
None yet
Milestone
Sprint 12
Development

Successfully merging a pull request may close this issue.

issue #1052 - ignore non-return parameter "general parameters" in search LinuxForHealth/FHIR
1 participant
@lmsurpre