ibm_database deletion_protection should be documented as only being a terraform hack

[brackendawson]

Community Note

• Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request
• If you are interested in working on this issue or have submitted a pull request, please leave a comment

New or Affected Resource(s) or Datasource(s)

• ibm_database

Description

Having upgraded from 0.63.0 to 0.70.0 I noticed that the provider was now planning to set a deletion_protection property on my databases. I attempted to check the current state of this property on my databases but was completely unable to find it. This is because it's not there, deletion_protection does not exist in the resource, it is a hack which lives entirely within terraform to crash rather than deleting databases.

It should be 100% clear from the provider's documentation that this is not a setting on the database. this is the current documentation:

deletion_protection - (Optional, Boolean) If the DB instance should have deletion protection enabled. The database can't be deleted when this value is set to true. The default is false.

I would suggest:

deletion_protection - (Optional, Boolean) If the DB instance should have deletion protection within terraform enabled. This is not a property of the resource and does not prevent deletion outside of terraform. The database can't be deleted by terraform when this value is set to true. The default is false.

References

• Add deletion_protection argument to database resource #5534