Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incorrect handling of trusted profile static CRN identities #5681

Merged

Conversation

Daniel-Byrne
Copy link
Contributor

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Fixes a bug handling identity id when that id contains a CRN.

Output from acceptance testing:

$ make testacc TEST=./ibm/service/iamidentity/resource_ibm_iam_trusted_profile_identity_test.go

=== RUN   TestAccIBMIamTrustedProfileIdentityBasic
--- PASS: TestAccIBMIamTrustedProfileIdentityBasic (43.22s)

=== RUN   TestAccIBMIamTrustedProfileIdentityAllArgs
--- PASS: TestAccIBMIamTrustedProfileIdentityAllArgs (35.84s)
PASS

@Daniel-Byrne Daniel-Byrne force-pushed the iamidentity-incorrect-crn-handling branch from d2c0511 to 58ccaa0 Compare September 24, 2024 13:44
@hkantare
Copy link
Collaborator

@Daniel-Byrne Can you update the respective document import section with new ID format.

@Daniel-Byrne
Copy link
Contributor Author

Hi @hkantare. I am not sure which section you are referring to?

@Daniel-Byrne Daniel-Byrne force-pushed the iamidentity-incorrect-crn-handling branch from 58ccaa0 to 07437b1 Compare September 27, 2024 07:42
@Daniel-Byrne
Copy link
Contributor Author

@hkantare Done. Thanks.

@hkantare hkantare merged commit c319f23 into IBM-Cloud:master Sep 30, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants