Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow resizing kubernetes service worker-pools to 0 #5460

Merged

Conversation

TwoDCube
Copy link
Contributor

@TwoDCube TwoDCube commented Jun 23, 2024

IKS introduced the ability to resize an existing worker-pool to 0, so we have to allow that in the terraform provider as well.

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Output from acceptance testing:

% export TESTARGS='-run "(TestAccIBMContainerWorkerPoolBasic|TestAccIBMContainerWorkerPoolZeroSize|TestAccIBMContainerWorkerPoolInvalidSizePerZone)"'
% make testacc
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test $(go list ./... |grep -v 'vendor') -v -run "(TestAccIBMContainerWorkerPoolBasic|TestAccIBMContainerWorkerPoolZeroSize|TestAccIBMContainerWorkerPoolInvalidSizePerZone)" -timeout 700m
?   	github.com/IBM-Cloud/terraform-provider-ibm	[no test files]
?   	github.com/IBM-Cloud/terraform-provider-ibm/ibm/acctest	[no test files]
?   	github.com/IBM-Cloud/terraform-provider-ibm/ibm/provider	[no test files]

[...]

=== RUN   TestAccIBMContainerWorkerPoolBasic
--- PASS: TestAccIBMContainerWorkerPoolBasic (1244.19s)
=== RUN   TestAccIBMContainerWorkerPoolZeroSize
--- PASS: TestAccIBMContainerWorkerPoolZeroSize (1483.26s)
=== RUN   TestAccIBMContainerWorkerPoolInvalidSizePerZone
--- PASS: TestAccIBMContainerWorkerPoolInvalidSizePerZone (0.32s)
PASS
ok  	github.com/IBM-Cloud/terraform-provider-ibm/ibm/service/kubernetes	2732.484s

[...]

@hkantare hkantare merged commit 4e14590 into IBM-Cloud:master Jun 24, 2024
1 check passed
@TwoDCube TwoDCube deleted the zoltanszepesi/allow-zero-workerpool-size branch June 24, 2024 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants