Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

P10 enablement for SAP #3534

Merged
merged 3 commits into from
Feb 11, 2022
Merged

P10 enablement for SAP #3534

merged 3 commits into from
Feb 11, 2022

Conversation

ChaseRun
Copy link
Collaborator

@ChaseRun ChaseRun commented Feb 2, 2022

  • Add ability to deploy SAP instance on E1080
  • Updated SAP resource tests to specify SysType
  • Implemented updated ibmpisession
  • Minor updates to variable names based on updated Power API

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates OR Closes #0000

Output from acceptance testing:

=== RUN   TestAccIBMPISAPInstance
--- PASS: TestAccIBMPISAPInstance (1436.03s)
PASS

@yussufsh yussufsh added the service/Power Systems Issues related to Power Systems label Feb 3, 2022
yussufsh
yussufsh requested changes Feb 7, 2022
View reviewed changes
go.mod Outdated Show resolved Hide resolved
ibm/service/power/resource_ibm_pi_ike_policy.go Outdated Show resolved Hide resolved
ibm/service/power/resource_ibm_pi_instance_test.go Outdated Show resolved Hide resolved
website/docs/r/pi_instance.html.markdown Outdated Show resolved Hide resolved
P10 enablement for SAP
fb68792 
 - Add ability to deploy SAP instance on E1080
 - Updated SAP resource tests to specify SysType
 - Implemented updated ibmpisession
 - Minor updates to variable names based on updated Power API
yussufsh
yussufsh reviewed Feb 10, 2022
View reviewed changes
go.sum Outdated Show resolved Hide resolved
yussufsh
yussufsh approved these changes Feb 10, 2022
View reviewed changes
Copy link
Collaborator

@yussufsh yussufsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@hkantare hkantare merged commit a6e59ae into IBM-Cloud:master Feb 11, 2022
@ChaseRun ChaseRun deleted the P10 branch February 15, 2022 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rmoralesjr rmoralesjr rmoralesjr left review comments

@yussufsh yussufsh yussufsh approved these changes

@kavya498 kavya498 Awaiting requested review from kavya498

@hkantare hkantare Awaiting requested review from hkantare

Assignees
No one assigned
Labels
service/Power Systems Issues related to Power Systems
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ChaseRun @yussufsh @rmoralesjr @hkantare