From f183b9e8219b10691e9b27641d661fb29d5d49cb Mon Sep 17 00:00:00 2001 From: Hayden Date: Thu, 22 Mar 2018 12:51:28 +0000 Subject: [PATCH] Drop support for Python 3.4 The reasons for removal are details in #300 At this very point, the code still works with Python 3.4. Testing against this version, however, is being stopped. This means that at some unknown point in the future pyIATI will stop working with Python 3.4. --- .travis.yml | 1 - CHANGELOG.md | 2 ++ iati/resources.py | 4 ++-- setup.py | 1 - 4 files changed, 4 insertions(+), 4 deletions(-) diff --git a/.travis.yml b/.travis.yml index b0e103a8..2a541344 100644 --- a/.travis.yml +++ b/.travis.yml @@ -3,7 +3,6 @@ cache: pip python: - 2.7 - - 3.4 - 3.5 - 3.6 install: diff --git a/CHANGELOG.md b/CHANGELOG.md index 266930ac..16e876e2 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -47,6 +47,8 @@ The format is based on [Keep a Changelog](http://keepachangelog.com/en/1.0.0/) a - [Resources] Functions in the `resources` module no longer have default values for the `version` argument. [#297] +- [Compatibility] Drop support for Python 3.4. [#309] + ### Fixed - [Constants] `STANDARD_VERSIONS` now lists all versions of the Standard, not just those that are fully supported by pyIATI. [#223] diff --git a/iati/resources.py b/iati/resources.py index 3b1b8e9b..4702c805 100644 --- a/iati/resources.py +++ b/iati/resources.py @@ -462,7 +462,7 @@ def path_for_version(path, version): Does not check whether anything exists at the specified path. """ - try: # python2 and python3.4 compatibility + try: # python2 compatibility _ensure_portable_filepath(path) except ValueError: if path != '': @@ -516,7 +516,7 @@ def _ensure_portable_filepath(maybe_filepath): This restriction is currently tight since it's easier to tighten than loosen restrictions. The restriction could be relaxed over time. Todo: - Consider utilising the Python3.4 concept of path-like objects. + Consider utilising the Python3 concept of path-like objects from the pathlib module. """ if not isinstance(maybe_filepath, str): diff --git a/setup.py b/setup.py index 265fa55b..c300beeb 100644 --- a/setup.py +++ b/setup.py @@ -30,7 +30,6 @@ 'Operating System :: OS Independent', 'Programming Language :: Python', 'Programming Language :: Python :: 2.7', - 'Programming Language :: Python :: 3.4', 'Programming Language :: Python :: 3.5', 'Programming Language :: Python :: 3.6', 'Topic :: Scientific/Engineering :: Information Analysis',