Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Strange data in tutorial for aggregating and stacked plots #265

Open
danielhuppmann opened this issue Sep 4, 2019 · 2 comments
Open

Strange data in tutorial for aggregating and stacked plots #265

danielhuppmann opened this issue Sep 4, 2019 · 2 comments

Comments

@danielhuppmann
Copy link
Member

Using the stack_plot() feature and experiencing some strange behaviour, I went to the aggregating_variables_and_plotting_with_negative_values tutorial notebook (#198) to see check whether I was doing something wrong.

I noticed that the test data are a bit ... counter-intuitive. Is this dataset based on real scenario data, or just completely made up?

Specifically:

  • Units/values are not in line with actual global data
  • Is 'Emissions|CO2|Agg' supposed to be agriculture?
  • Why are specifically 'Emissions|CO2|Energy|BECCS' both positive and negative? I would expect this variable in particular to be negative-only...

@rossursino @znicholls, any comments?

@znicholls
Copy link
Collaborator

znicholls commented Sep 4, 2019

Is this dataset based on real scenario data, or just completely made up?

Completely made up, can edit however makes sense to you. We just chose the data to make sure the features we cared about all worked (e.g. it could handle timeseries which were only positive, only negative, started positive then went negative, started positive then went negative then went positive again).

@danielhuppmann
Copy link
Member Author

Thanks @znicholls - see related issue #266 - stack_plot() completely removes timeseries that start with zero values.

Will see if I can fix that and will update the illustrative dataset in the tutorial as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants