Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor Dreame fixes #969

Closed
wants to merge 2 commits into from
Closed

Minor Dreame fixes #969

wants to merge 2 commits into from

Conversation

ccoors
Copy link
Contributor

@ccoors ccoors commented Jun 25, 2021

Minor Dreame fixes

Type A:

  • Bug fix (non-breaking change which fixes an issue)
  • Refactor/Code Cleanup
  • Docs
  • Capability implementation for existing core capability
  • New robot implementation

Type B:

  • New capability
  • New core feature

Description (Type A)

  • Add the power save status - alternative: just map to "idle" instead?
  • Ignore property changes for audio volume (basically just to remove the "Unhandled property change" log entries)

Hypfer
Hypfer reviewed Jun 25, 2021
View reviewed changes
backend/lib/entities/state/attributes/StatusStateAttribute.js
@@ -37,7 +37,8 @@ StatusStateAttribute.VALUE = Object.freeze({
CLEANING: "cleaning",
PAUSED: "paused",
MANUAL_CONTROL: "manual_control",
MOVING: "moving"
MOVING: "moving",
POWER_SAVE: "power_save"
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not a minor bugfix 👀

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Debatable.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So just map it to idle? That would be fine for me too. Docked is definitely wrong though.

@Hypfer Hypfer closed this in 68c1c0c Jun 25, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 26, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Hypfer Hypfer Hypfer left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ccoors @Hypfer