MockCarpetModeControlCapability #759
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Why do we need a persistent state? |
|
Well, for instance, the initial idea was that if you want to debug an issue that only occurs eg. when the robot is cleaning, the battery is < 50 % and the carpet detection is off, you only have to get your virtual robot into that state once. When you restart Valetudo the previous state is restored. Idk if it is useful, it's up for discussion. |
|
For this I would not implement a dynamically saved state, but rather multiple config parameters in the implementationSpecificConfig, to bring the robot into a defined state on startup. What do you think @Hypfer ? Maybe you should split the PR, MockCarpetModeControlCapability is ok to merge. |
|
+1 to that |
ccoors
force-pushed
the
feature/mock-robot-enhancements
branch
from
3e74405 to
93ce09f
Compare
|
Yeah, you are right. Removed that second commit. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MockRobot features
Type A:
Type B:
Description (Type A)
Adds the
MockCarpetModeControlCapability