fix(vendor.roborock): Fix resetting incomplete map on Roborock. Detect and reset current map slot. #1252
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t and reset current map slot.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Type A:
Description (Type A)
This PR adds 2 fixes or rather improvements to RoborockMultiMapResetCapability.
Roborocks can't delete current map if it's incomplete. You either have to save it manually first, or complete a full clean-up which ends with an auto-saving of the map to the first available slot. Since Valetudo has no concept of multi-map management, there's no way to save it manually. This PR adds an implicit map saving when reset is attempted with an incomplete map.
Since Valetudo has no concept of multi-maps and performs actions against currently active map, it is reasonable to expect that it resets current map. Current map is not necessarily the one with id: 0. Even though Valetudo can't switch to a different map, user could do it through the official app or with other tools. So it's not entirely safe to assume current map id to be 0. This PR adds detection of currently used map slot to reset the correct map.