Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ui): Use real swagger icon in sidebar #1160

Merged
merged 1 commit into from
Oct 15, 2021
Merged

feat(ui): Use real swagger icon in sidebar #1160

merged 1 commit into from
Oct 15, 2021

Conversation

ccoors
Copy link
Contributor

@ccoors ccoors commented Oct 14, 2021

Type of change

Type A:

  • Bug fix (non-breaking change which fixes an issue)
  • UI Feature
  • Refactor/Code Cleanup
  • Docs
  • Capability implementation for existing core capability
  • New robot implementation

Type B:

  • New capability
  • New core feature

Description (Type A)

Use the real swagger icon in the sidebar.

image

@Hypfer
Copy link
Owner

Hypfer commented Oct 15, 2021

Can we do that? As in: Does their license allow doing that?

@Hypfer
Copy link
Owner

Hypfer commented Oct 15, 2021

Informational (or "editorial") uses of a trademark do not require permission from its owner. These are uses that inform, educate, or express opinions protected under the First Amendment of the United States Constitution—freedom of speech and of the press.

Hm. Whatever

@Hypfer Hypfer merged commit f4c0093 into Hypfer:master Oct 15, 2021
@ccoors ccoors deleted the feature/ui-swagger-icon branch October 15, 2021 08:02
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 16, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ccoors @Hypfer