Added tests for Greek deleted obsolet entries in resx. Corrected Roma… #636
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nian and marked both with "Native speaker"
39 tasks
|
There's a lot of deletes in there -- are we not using those anymore where did they go and how about the other languages, do they also have those? |
|
The deleted entries are not used by by the DefaultFormatter used by the Greek language. Other languages use special rules (e.g. RussianFormatter appends "_Paucal" (for number 2 to 4) or _"Singular" (for numbers ending with 1)). Most languages like German don't have the entries ending with _Above20, _Dual, _Plural, _Singular, _TrialQuadral. All entries I deleted were duplicates, so actually no information is lost. |
|
Thanks for the explanation. We ought to have a Wiki entry on what's needed for different languages. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…nian and marked both with "Native speaker"
Corrections of the Romanian language as reviewed by @ds-b in #632