Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding welsh (cy) support #1529

Open
IeuanWalker opened this issue Jul 24, 2024 · 2 comments
Open

Adding welsh (cy) support #1529

IeuanWalker opened this issue Jul 24, 2024 · 2 comments

Comments

@IeuanWalker
Copy link

Hi, I've created a POC project for my workplace, and that piece of work is going ahead now. Our current app supports the Welsh language so looking to see if/ how I create a PR for it.

Currently, we only need support for DateTimeOffset.Humanize -
image

So I'd like to do a PR to add support for that function, but would like to add support for all the features.

Some background, I work for Cardiff city, which is the capital of Wales and the Welsh language. We have our own in-house translation team for Welsh language

@hangy
Copy link
Contributor

hangy commented Jul 29, 2024

I believe every language support is highly welcome! 👍🏻 Generally, it's not a problem to start with one feature for a language and to add others gradually. It looks like DateTimeOffset.Humanize is mostly based off of resource files, but unit tests to ensure that everything works as expected would be necessary. #924 looks like a good sample of adding support for a new culture.

@IeuanWalker IeuanWalker mentioned this issue Aug 16, 2024
11 tasks
@IeuanWalker
Copy link
Author

thanks @hangy, i've created a PR, would you know the answers to the questions i left in a comment on there?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants