Skip to content

Commit

Permalink
Incorporated review comments by @khellang, @M-Zuber, @jeremymeng. Mar…
Browse files Browse the repository at this point in the history
…ked reviewed language with "Native speaker". Marked 'sv' as reviewed even confirmation is pending.
  • Loading branch information
MaStr11 committed May 4, 2017
1 parent 4c64630 commit 5a38789
Show file tree
Hide file tree
Showing 11 changed files with 27 additions and 27 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,8 @@ public class TimeSpanHumanizeTests
{

[Theory]
[Trait("Translation", "Google")]
[InlineData(366, "en år")]
[Trait("Translation", "Native speaker")]
[InlineData(366, "et år")]
[InlineData(731, "2 år")]
[InlineData(1096, "3 år")]
[InlineData(4018, "11 år")]
Expand All @@ -19,7 +19,7 @@ public void Years(int days, string expected)
}

[Theory]
[Trait("Translation", "Google")]
[Trait("Translation", "Native speaker")]
[InlineData(31, "en måned")]
[InlineData(61, "2 måneder")]
[InlineData(92, "3 måneder")]
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -8,9 +8,9 @@ public class TimeSpanHumanizeTests
{

[Theory]
[Trait("Translation", "Google")]
[InlineData(366, "שנה אחת")]
[InlineData(731, "שנים")]
[Trait("Translation", "Native speaker")]
[InlineData(366, "שנה")]
[InlineData(731, "שנתיים")]
[InlineData(1096, "3 שנים")]
[InlineData(4018, "11 שנים")]
public void Years(int days, string expected)
Expand All @@ -19,9 +19,9 @@ public void Years(int days, string expected)
}

[Theory]
[Trait("Translation", "Google")]
[Trait("Translation", "Native speaker")]
[InlineData(31, "חודש")]
[InlineData(61, "חודשים")]
[InlineData(61, "חודשיים")]
[InlineData(92, "3 חודשים")]
[InlineData(335, "11 חודשים")]
public void Months(int days, string expected)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ public class TimeSpanHumanizeTests
{

[Theory]
[Trait("Translation", "Google")]
[Trait("Translation", "Native speaker")]
[InlineData(366, "ett år")]
[InlineData(731, "2 år")]
[InlineData(1096, "3 år")]
Expand All @@ -20,7 +20,7 @@ public void Years(int days, string expected)


[Theory]
[Trait("Translation", "Google")]
[Trait("Translation", "Native speaker")]
[InlineData(31, "en måned")]
[InlineData(61, "2 måneder")]
[InlineData(92, "3 måneder")]
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -57,8 +57,8 @@ public void Weeks(int number, string expected)


[Theory]
[Trait("Translation", "Google")]
[InlineData(31, "1 månad")]
[Trait("Translation", "Native speaker")]
[InlineData(31, "en månad")]
[InlineData(61, "2 månader")]
[InlineData(92, "3 månader")]
[InlineData(335, "11 månader")]
Expand All @@ -68,8 +68,8 @@ public void Months(int days, string expected)
}

[Theory]
[Trait("Translation", "Google")]
[InlineData(366, "1 år")]
[Trait("Translation", "Native speaker")]
[InlineData(366, "ett år")]
[InlineData(731, "2 år")]
[InlineData(1096, "3 år")]
[InlineData(4018, "11 år")]
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ public class TimeSpanHumanizeTests
{

[Theory]
[Trait("Translation", "Google")]
[Trait("Translation", "Native speaker")]
[InlineData(366, "1 年")]
[InlineData(731, "2 年")]
[InlineData(1096, "3 年")]
Expand All @@ -19,7 +19,7 @@ public void Years(int days, string expected)
}

[Theory]
[Trait("Translation", "Google")]
[Trait("Translation", "Native speaker")]
[InlineData(31, "1 个月")]
[InlineData(61, "2 个月")]
[InlineData(92, "3 个月")]
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ public class TimeSpanHumanizeTests
{

[Theory]
[Trait("Translation", "Google")]
[Trait("Translation", "Native speaker")]
[InlineData(366, "1 年")]
[InlineData(731, "2 年")]
[InlineData(1096, "3 年")]
Expand All @@ -19,7 +19,7 @@ public void Years(int days, string expected)
}

[Theory]
[Trait("Translation", "Google")]
[Trait("Translation", "Native speaker")]
[InlineData(31, "1 个月")]
[InlineData(61, "2 个月")]
[InlineData(92, "3 个月")]
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ public class TimeSpanHumanizeTests
{

[Theory]
[Trait("Translation", "Google")]
[Trait("Translation", "Native speaker")]
[InlineData(366, "1 年")]
[InlineData(731, "2 年")]
[InlineData(1096, "3 年")]
Expand All @@ -20,7 +20,7 @@ public void Years(int days, string expected)
}

[Theory]
[Trait("Translation", "Google")]
[Trait("Translation", "Native speaker")]
[InlineData(31, "1 個月")]
[InlineData(61, "2 個月")]
[InlineData(92, "3 個月")]
Expand Down
2 changes: 1 addition & 1 deletion src/Humanizer/Properties/Resources.da.resx
Original file line number Diff line number Diff line change
Expand Up @@ -241,6 +241,6 @@
<value>en måned</value>
</data>
<data name="TimeSpanHumanize_SingleYear" xml:space="preserve">
<value>en år</value>
<value>et år</value>
</data>
</root>
6 changes: 3 additions & 3 deletions src/Humanizer/Properties/Resources.he.resx
Original file line number Diff line number Diff line change
Expand Up @@ -417,7 +417,7 @@
<value>{0} חודשים</value>
</data>
<data name="TimeSpanHumanize_MultipleMonths_Dual" xml:space="preserve">
<value>חודשים</value>
<value>חודשיים</value>
</data>
<data name="TimeSpanHumanize_MultipleMonths_Plural" xml:space="preserve">
<value>{0} חודשים</value>
Expand All @@ -426,7 +426,7 @@
<value>{0} שנים</value>
</data>
<data name="TimeSpanHumanize_MultipleYears_Dual" xml:space="preserve">
<value>שנים</value>
<value>שנתיים</value>
</data>
<data name="TimeSpanHumanize_MultipleYears_Plural" xml:space="preserve">
<value>{0} שנים</value>
Expand All @@ -435,6 +435,6 @@
<value>חודש</value>
</data>
<data name="TimeSpanHumanize_SingleYear" xml:space="preserve">
<value>שנה אחת</value>
<value>שנה</value>
</data>
</root>
4 changes: 2 additions & 2 deletions src/Humanizer/Properties/Resources.sv.resx
Original file line number Diff line number Diff line change
Expand Up @@ -238,9 +238,9 @@
<value>{0} år</value>
</data>
<data name="TimeSpanHumanize_SingleMonth" xml:space="preserve">
<value>1 månad</value>
<value>en månad</value>
</data>
<data name="TimeSpanHumanize_SingleYear" xml:space="preserve">
<value>1 år</value>
<value>ett år</value>
</data>
</root>
2 changes: 1 addition & 1 deletion src/Humanizer/TimeSpanHumanizeExtensions.cs
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ public static string Humanize(this TimeSpan timeSpan, int precision = 1, Culture
/// <param name="precision">The maximum number of time units to return.</param>
/// <param name="countEmptyUnits">Controls whether empty time units should be counted towards maximum number of time units. Leading empty time units never count.</param>
/// <param name="culture">Culture to use. If null, current thread's UI culture is used.</param>
/// <param name="maxUnit">The maximum unit of time to output. The default value is <see cref="TimeUnit.Week"/>. The time units <see cref="TimeUnit.Month"/> and <see cref="TimeUnit.Year"/> will give approximations for time spans bigger 30 days by calculating with 365.2425 days a year and 30.4369 days a month.</param>
/// <param name="maxUnit">The maximum unit of time to output. The default value is <see cref="TimeUnit.Week"/>. The time units <see cref="TimeUnit.Month"/> and <see cref="TimeUnit.Year"/> will give approximations for time spans bigger than 30 days by calculating with 365.2425 days a year and 30.4369 days a month.</param>
/// <param name="minUnit">The minimum unit of time to output.</param>
/// <param name="collectionSeparator">The separator to use when combining humanized time parts. If null, the default collection formatter for the current culture is used.</param>
/// <returns></returns>
Expand Down

0 comments on commit 5a38789

Please sign in to comment.