Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to using pathlib #531

Closed
levmckinney opened this issue Aug 22, 2022 · 2 comments · Fixed by #537
Closed

Switch to using pathlib #531

levmckinney opened this issue Aug 22, 2022 · 2 comments · Fixed by #537
Assignees

Comments

@levmckinney
Copy link
Collaborator

Why aren't we using Pathlib?

Originally posted by @Rocamonde in #529 (comment)

@Rocamonde
Copy link
Member

Rocamonde commented Aug 22, 2022

I'll prepare a PR for this as I've used Pathlib extensively, subject to others agreeing with this switch.

@AdamGleave
Copy link
Member

We already use it in some places:

find src/imitation -name '*.py' | xargs grep "import pathlib"
src/imitation/algorithms/dagger.py:import pathlib
src/imitation/data/types.py:import pathlib
src/imitation/util/sacred.py:import pathlib
src/imitation/policies/serialize.py:import pathlib

It's not a priority to me but happy to see us use it, I think it does make sense to switch.

@Rocamonde Rocamonde self-assigned this Aug 23, 2022
@Rocamonde Rocamonde mentioned this issue Aug 24, 2022
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants