Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PropertyNamingStrategyWrapper looks for deprecated PropertyNamingStrategy.LOWER_CAMEL_CASE #95

Closed
alievrenkut opened this issue Dec 15, 2022 · 3 comments

Comments

@alievrenkut
Copy link

New version of Jackson start using PropertyNamingStrategies.LOWER_CAMEL_CASE for default. Could you update the code to check for this for NoOpNamingStrategy. Below you can find suggested change:

public PropertyNamingStrategyWrapper(PropertyNamingStrategy delegate) {
        if (delegate instanceof PropertyNamingStrategy.PropertyNamingStrategyBase) {
            this.delegate = (PropertyNamingStrategy.PropertyNamingStrategyBase)delegate;
        } else if (delegate == PropertyNamingStrategy.LOWER_CAMEL_CASE 
|| delegate == PropertyNamingStrategies.LOWER_CAMEL_CASE) { // suggested change
            this.delegate = NO_OP;
        } else {
            this.delegate = SNAKE_TO_CAMEL;
        }

    }
@jhaber
Copy link
Member

jhaber commented Jul 13, 2023

👋 which version of jackson has this change? I'm not able to reproduce on jackson 2.12, 2.13, 2.14, or 2.15

@cowtowncoder
Copy link

I am not aware of any change in Jackson to force naming strategy, or change defaults.

But I assume this might be about deprecation of constants in PropertyNamingStrategy (as per FasterXML/jackson-databind#2715) and moving to use ones from PropertyNamingStrategies instead.
This change would have gone in 2.12.0.

@jhaber
Copy link
Member

jhaber commented Jul 14, 2023

I believe that was handled in #88 Going to close this out, but feel free to reopen if I missed something

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants