Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make using environment variable based config explicit when running commands #257

Closed
miketalley opened this issue Jul 8, 2020 · 3 comments · Fixed by #317
Closed

Make using environment variable based config explicit when running commands #257

miketalley opened this issue Jul 8, 2020 · 3 comments · Fixed by #317
Assignees

Comments

@miketalley
Copy link
Contributor

Currently, when you have the required environment variables set, it will override the hubspot.config.yml settings. This can be a problem if the variables are set unbeknownst to the user and commands are attempted to be run using the hubspot.config.yml settings.

We should look into adding an option to commands to explicitly use the environment variable config like hs watch --use-env or something similar. Research some different options for this.

@drewjenkins
Copy link
Contributor

This would be a potentially breaking change for users right? Since it would now use the hubspot.config.yml instead of their env vars unless they add this flag. We'll need to communicate it and major bump again

@miketalley
Copy link
Contributor Author

miketalley commented Sep 17, 2020

Yes, the change here has the potential to break a setup that is currently using the environment variables because it would require adding the option flag. We have not publicly released/documented/announced this feature so I think we are in the clear here as we make the option required prior to the official release

@TheWebTech
Copy link
Contributor

Appreciate the forethought Andrew. In this case like Mike said i think we can do this safely as env variables have never been documented.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants