From 4c0a0ba40c00b35d7d65b4b6979725d679a357d4 Mon Sep 17 00:00:00 2001 From: Stephen Salinas Date: Thu, 15 Sep 2016 14:17:45 -0400 Subject: [PATCH 1/2] Make deployHistory bytes a MEDIUMBLOB --- mysql/migrations.sql | 2 ++ 1 file changed, 2 insertions(+) diff --git a/mysql/migrations.sql b/mysql/migrations.sql index e39b530cca..748d11e13c 100644 --- a/mysql/migrations.sql +++ b/mysql/migrations.sql @@ -109,3 +109,5 @@ UPDATE `taskHistory` SET `startedAt` = FROM_UNIXTIME(SUBSTRING_INDEX(SUBSTRING_I ALTER TABLE `taskHistory` ADD KEY `updatedAt` (`updatedAt`, `requestId`) +--changeset ssalinas:13 dbms:mysql +ALTER TABLE `deployHistory` MODIFY `bytes` MEDIUMBLOB NOT NULL; From 161f381f6bf3d045829adc8596635b0627b1dbd0 Mon Sep 17 00:00:00 2001 From: Stephen Salinas Date: Thu, 15 Sep 2016 14:24:51 -0400 Subject: [PATCH 2/2] don't need to log full deploy history, will be logged by mysql error --- .../data/history/SingularityDeployHistoryPersister.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/SingularityService/src/main/java/com/hubspot/singularity/data/history/SingularityDeployHistoryPersister.java b/SingularityService/src/main/java/com/hubspot/singularity/data/history/SingularityDeployHistoryPersister.java index 69595b15e7..0da59206a1 100644 --- a/SingularityService/src/main/java/com/hubspot/singularity/data/history/SingularityDeployHistoryPersister.java +++ b/SingularityService/src/main/java/com/hubspot/singularity/data/history/SingularityDeployHistoryPersister.java @@ -112,7 +112,7 @@ protected boolean moveToHistory(SingularityDeployHistory deployHistory) { try { historyManager.saveDeployHistory(deployHistory); } catch (Throwable t) { - LOG.warn("Failed to persist deploy {} history ({})", SingularityDeployKey.fromDeployMarker(deployHistory.getDeployMarker()), deployHistory, t); + LOG.warn("Failed to persist deploy {}", SingularityDeployKey.fromDeployMarker(deployHistory.getDeployMarker()), t); return false; }