Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accessing GQL store while loading in an other route breaks SSR #452

Closed
janvotava opened this issue Aug 4, 2022 · 2 comments · Fixed by #449
Closed

Accessing GQL store while loading in an other route breaks SSR #452

janvotava opened this issue Aug 4, 2022 · 2 comments · Fixed by #449
Assignees
Labels
Bug Something isn't working like it should

Comments

@janvotava
Copy link
Contributor

Demo: https://github.com/janvotava/houdini-error-reproduce-001

When the $GQL store is read in the __layout.svelte, the resulting data in the routes/index.svelte will be null for some reason and SSR won't work.

@AlecAivazis AlecAivazis self-assigned this Aug 4, 2022
@AlecAivazis
Copy link
Collaborator

AlecAivazis commented Aug 4, 2022

After digging into this a bit, it turns out that the issue is that the store's value gets deleted from the unsubscribe which erases the value being rendered (at least that's my current working model). I have a branch with a failing test here: https://github.com/HoudiniGraphql/houdini/tree/same-store-twice.

Since fixing this is a slightly larger effort, I'd like to wait until #449 is in so we don't have a lot of conflicts to sift through. Once that goes in, fixing this will be at the top of our list

@AlecAivazis AlecAivazis added the Bug Something isn't working like it should label Aug 4, 2022
@AlecAivazis
Copy link
Collaborator

I have a hunch that #449 will fix this. hopefully one of us will remember to confirm when its merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working like it should
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants