Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Share app to chocolatey.org #208

Closed
picu63 opened this issue Oct 7, 2021 · 11 comments
Closed

[Feature] Share app to chocolatey.org #208

picu63 opened this issue Oct 7, 2021 · 11 comments
Assignees
Labels
Milestone

Comments

@picu63
Copy link

picu63 commented Oct 7, 2021

Hi,
I'll be nice if SystemTrayMenu will be on chocolatey.org or other similar package provider.
Specially when taskbar in Windows 11 is highly limited.
Thanks

@topeterk
Copy link
Collaborator

topeterk commented Oct 7, 2021

It should be available at the Microsoft Store on Windows 11 as well, right?

@Tanjalibertatis
Copy link
Collaborator

@Tanjalibertatis
Copy link
Collaborator

Tanjalibertatis commented Nov 28, 2021

2021-11-28 21_44_10-Administrator_ Windows PowerShell

Check status here: https://community.chocolatey.org/packages/systemtraymenu/1.1.1.0

(the documentation to create an update is here #255)

@Hofknecht Hofknecht added this to the 1.2 milestone Dec 5, 2021
@Tanjalibertatis
Copy link
Collaborator

-files for package are located at C:\Windows\System32\SystemTrayMenu

2021-12-12 13_02_50-Window
=> VERIFICATION.txt file missing when binaries included (package)

So I added a file named VERIFICATION.txt (located at C:\Windows\System32\test\tools\VERIFICATION.txt) with
choco new test
edited and put it into C:\Windows\System32\SystemTrayMenu\tools

After that I updated everything to new version 1.2.0.0 and pushed to chocolatey.

Check status here: https://community.chocolatey.org/packages/systemtraymenu/1.2.0.0

@Hofknecht Hofknecht modified the milestones: 1.2, 1.3 Dec 12, 2021
@phanirithvij
Copy link

phanirithvij commented Jan 13, 2022

FYI: It is available via Scoop

@Tanjalibertatis
Copy link
Collaborator

Tanjalibertatis commented Feb 3, 2022

package was reviewed, but there are some changes to make:

  1. The iconUrl should be switched from github raw to a CDN: https://docs.chocolatey.org/en-us/create/create-packages#package-icon-guidelines
    => done by using https://statically.io/
  2. The checksums need to be filled in.
    => done by filling in the checksum for the systemtraymenu.exe in the file chocolateyinstall.ps1
  3. Are you the author of this software? If you are, please confirm with a comment here. If you are not, can you please put your Chocolatey username in the owners field in the nuspec and the software author's name in the authors field.
    => done by commenting discussion with "Yes, I am the author of this software."
  4. The packageSourceUrl is for the source for the Chocolatey package (e.g. the .nuspec, chocolateyinstall.ps1, etc), not for where the source for the software that the package installs is.
    => done by deleting packageSourceUrl in the file systemtraymenu.nuspec, because it's optional
  5. Since the 32 bit and 64 bit urls are the same, the 64 bit url and checksum can be removed. Chocolatey will go ahead and use the 32 bit url on 64 bit systems
    => done by deleting those (4 lines) in the file chocolateyinstall.ps1
  6. Please fill in the VERIFICATION.txt with explicit steps on how to verify the included binaries are the same as the binaries published by the project. Example: https://github.com/chocolatey-community/chocolatey-coreteampackages/blob/master/automatic/7zip.install/legal/VERIFICATION.txt
    => done by adding an instruction and checksum to the file VERIFICATION.txt
  7. Please fill in the LICENSE.txt instead of just using a license identifier.
    => done by copying the whole license text
  8. Since the package is extracting a zip with Install-ChocolateyZipPackage into the $toolsDir, there should be no need for the uninstall script.
    => done by deleting the file chocolateyuninstall.ps1

(important addition from mail: 'repush your updated package with the exact same version')

=> just repushed

@Tanjalibertatis
Copy link
Collaborator

The reviewer answered:

So looking back at this package, it seems like the included files in the .nupkg are the same as the files in the archive that is downloaded and extracted with the install script. Is that correct?

So I actually think you don't need the install script at all, if that is the case.

So I deleted chocolateyinstall.ps1 and repushed the package

@Tanjalibertatis
Copy link
Collaborator

Status Change - Changed status of package from 'submitted' to 'approved'.

Test also worked well.

Just pushed latest version 1.2.3.

@Tanjalibertatis
Copy link
Collaborator

FYI: It is available via Scoop

@phanirithvij that's nice, thank you!
So far we were not able to install SystemTrayMenu via scoop.
We found the GitHub bucket, thanks for that, we gave the project a star!

But when we type the commands
scoop install systemtraymenu or scoop install SystemTrayMenu
the following error message appears: Couldn't find manifest for 'systemtraymenu'.

Could you maybe help us?

@Tanjalibertatis
Copy link
Collaborator

Thank you @phanirithvij we got it now!
We have documented it here (#325) and will add it to the readme.

@phanirithvij
Copy link

@Tanjalibertatis I'm really sorry I missed this in my inbox. Thanks for adding it to the readme.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants