Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace attrs + marshmallow with pydantic #478

Open
hf-krechan opened this issue Sep 24, 2024 · 3 comments
Open

Replace attrs + marshmallow with pydantic #478

hf-krechan opened this issue Sep 24, 2024 · 3 comments

Comments

@hf-krechan
Copy link
Collaborator

The setup with attrs + marshmallow is not so easy to handle compared to pydantic.

At the moment the marshmallow-jsonschema needs setuptools as dependency which was a default package in the past.
But not anymore.
It seems to be insecure to add it into a package. I am not (yet) sure why.

We can streamline the dependencies by using just pydantic and it uses the same setup like in our other packages :)

@hf-krechan hf-krechan changed the title Replace attrs + marshmallow with pydantic Replace attrs + marshmallow with pydantic Sep 24, 2024
@hf-kklein
Copy link
Contributor

also using marshmallow-enum and marshmallow-jsonschema are more complicated than using pydantic, e.g. fuhrysteve/marshmallow-jsonschema#169

@hf-kklein
Copy link
Contributor

the replacement won't be trivial, because of our own union type-implementation

@hf-krechan
Copy link
Collaborator Author

but nothing which our all stars team can not handle ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants