Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve error message for dates chosen after end of contamination data #81

Closed
namurphy opened this issue Oct 12, 2022 · 2 comments
Closed

Comments

@namurphy
Copy link
Contributor

The bug raised in #74 occurred because a date was chosen after the end of the contamination data file. It would be helpful to have an error message for when a user picks a date that is after the end of the data contained in the contamination data file, like "No contamination data is presently available for ." This could be done in a try/except block.

@wtbarnes
Copy link
Collaborator

wtbarnes commented Nov 2, 2022

As someone who just hit the bug referenced above, I definitely agree. It wasn't immediately obvious to me that this is what the issue was or if I had just input the date incorrectly.

I wonder too if it would be possible to (maybe optionally) interpolate the last available contamination value to the current date if it is outside the range and issue a warning letting the user know this is what is happening. I would imagine this is likely a better estimate than being forced to not include any contamination at those dates.

@joyvelasquez
Copy link
Contributor

Close by #86

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants