Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multi-target hit detection appears to detect friendly NPCs in some cases. #7

Open
nckzvth opened this issue Jul 11, 2024 · 3 comments
Assignees
Labels
plugin bug Something isn't working

Comments

@nckzvth
Copy link

nckzvth commented Jul 11, 2024

Describe the bug
While completing the level 70 warrior quest, the two NPCs that you fight with were detected by Hilda. This caused the plugin to switch to the multi-target priority, even though there was only one enemy to hit. This leads me to believe that it may also happen in similar scenarios like the duty support queue.

To Reproduce
Steps to reproduce the behavior:

  1. Start the last phase of the level 70 warrior quest.
  2. While Main is toggled on, the plugin will detect the two friendly NPCs.
  3. See error

Expected behavior
The plugin should not detect NPCs that cannot be hit during an encounter.

Screenshots
image

@nckzvth nckzvth added the plugin bug Something isn't working label Jul 11, 2024
@bferrari352
Copy link
Collaborator

Hey, thanks for reporting this! Dalamud made some changes recently to the structure of GameObjects, and we didn't follow up on if it was working properly. Clearly it was not.

I've nailed down a fix so it will be in the next bug fix version.

@jcql
Copy link
Collaborator

jcql commented Jul 11, 2024

We reproduced this in some fates, hopefully fixed in 7.0.0.1 -- let us know!

@nckzvth
Copy link
Author

nckzvth commented Jul 13, 2024

I will be testing more over the weekend and will definitely reach out with additional feedback.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
plugin bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants