wrong extend edges effect

[imnak0]

I have UITabBarController, and first tab displays NavigationController.
The Root ViewController shows fine.
But if I push the second ViewController with hero enabled, then it extends edges under Tabbars, even though I unchecked the "Under Bottom Bars" in the Storyboard Option.

The weird thing is that if I select other tab and comes back to previous tab, then the viewcontroller shows correctly, not under-the-bottom-bars.

Any advice is greatly appreciated,

[lkzhao]

I am sick this week so won't be able to help you quickly. Could be a bug with Hero. Don't worry about it for now. I will see what I can do when I get better.

In the mean time you can hack a fix by setting the frame on your second view controller's view manually during viewWillAppear.

[lkzhao]

To make sure. You have a nav controller inside the first view controller of your tab bar controller, correct?

[lkzhao]

I am not seeing this when using auto layout. I pinned the square to the bottom edge. Not sure what your setup is. Can you upload a small demo? Are you laying out the views programmatically?

[imnak0]

here's demo for you
https://github.com/imnak0/HeroDemo

I'm not familiar with storyboard so please let me know if there's something wrong in my side, not on the hero code
Thanks a lot,

[lkzhao]

Should be fixed on the latest master, try:

pod "Hero", :git=>"https://github.com/lkzhao/Hero.git"

This is related to #60. Hero didn't set the frame correctly.