hr2 accumulate #70
Merged
hr2 accumulate #70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@HelinWei-NOAA @RongqianYang-NOAA @wzzheng90 Sorry for all the branches here, but I'm going to use this one to accumulate all the changes. Note there was a previous error in the z0m_hvt_ratio for two veg types fixed with 5c438fd. |
|
Leaving iopt_z0m = 2 after 5c438fd. Note everything after this will change answers. |
|
@HelinWei-NOAA @wzzheng90 @RongqianYang-NOAA I think I'm done with modifications. Note that I found some bug fixes in the NCAR repo that we should probably add. Also added canopy heat to parameter table for future tuning and removed zvfun/gdx effect from sfcdif3 (in a hacky way for now). |
HelinWei-NOAA
pushed a commit
that referenced
this pull request
Jun 27, 2023
Fix to allow for threading in RRTMGP
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Branch to accumulate all the changes going to HR2