Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

modify the eddy diffusivity for heat at the top of the canopy #21

Merged
merged 7 commits into from
Mar 21, 2022
Merged

modify the eddy diffusivity for heat at the top of the canopy #21

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
4284846
modify the eddy diffusivity for heat at the top of the canopy
wzzheng90 Mar 18, 2022
f3af80f
tuning cd/lm parameter
wzzheng90 Mar 20, 2022
96f58e0
tuning cd/lm parameter
wzzheng90 Mar 20, 2022
779b323
modify a table of cwp parameter
wzzheng90 Mar 21, 2022
09e4f95
modify a table of cwp parameter
wzzheng90 Mar 21, 2022
0b7879c
modify a table of cwp parameter
wzzheng90 Mar 21, 2022
109dcdf
modify a table of cwp parameter
wzzheng90 Mar 21, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 12 additions & 3 deletions physics/module_sf_noahmplsm.f90
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3828,6 +3828,7 @@ subroutine vege_flux(parameters,nsnow ,nsoil ,isnow ,vegtyp ,veg , &
real (kind=kind_phys) :: fm !momentum stability correction, weighted by prior iters
real (kind=kind_phys) :: fh !sen heat stability correction, weighted by prior iters
real (kind=kind_phys) :: fhg !sen heat stability correction, ground
real (kind=kind_phys) :: fhgh !sen heat stability correction, canopy
real (kind=kind_phys) :: hcan !canopy height (m) [note: hcan >= z0mg]

real (kind=kind_phys) :: a !temporary calculation
Expand Down Expand Up @@ -4048,7 +4049,7 @@ subroutine vege_flux(parameters,nsnow ,nsoil ,isnow ,vegtyp ,veg , &
call ragrb(parameters,iter ,vaie ,rhoair ,hg ,tah , & !in
zpd ,z0mg ,z0hg ,hcan ,uc , & !in
z0h ,fv ,cwp ,vegtyp ,mpe , & !in
tv ,mozg ,fhg ,iloc ,jloc , & !inout
tv ,mozg ,fhg ,fhgh ,iloc ,jloc , & !inout
ramg ,rahg ,rawg ,rb ) !out

! es and d(es)/dt evaluated at tv
Expand Down Expand Up @@ -4604,7 +4605,7 @@ end subroutine bare_flux
subroutine ragrb(parameters,iter ,vai ,rhoair ,hg ,tah , & !in
zpd ,z0mg ,z0hg ,hcan ,uc , & !in
z0h ,fv ,cwp ,vegtyp ,mpe , & !in
tv ,mozg ,fhg ,iloc ,jloc , & !inout
tv ,mozg ,fhg ,fhgh ,iloc ,jloc , & !inout
ramg ,rahg ,rawg ,rb ) !out
! --------------------------------------------------------------------------------------------------
! compute under-canopy aerodynamic resistance rag and leaf boundary layer
Expand Down Expand Up @@ -4638,6 +4639,7 @@ subroutine ragrb(parameters,iter ,vai ,rhoair ,hg ,tah , & !in

real (kind=kind_phys), intent(inout) :: mozg !monin-obukhov stability parameter
real (kind=kind_phys), intent(inout) :: fhg !stability correction
real (kind=kind_phys), intent(inout) :: fhgh !stability correction, canopy

! outputs
real (kind=kind_phys) :: ramg !aerodynamic resistance for momentum (s/m)
Expand All @@ -4652,29 +4654,36 @@ subroutine ragrb(parameters,iter ,vai ,rhoair ,hg ,tah , & !in
real (kind=kind_phys) :: tmprah2 !temporary calculation for aerodynamic resistances
real (kind=kind_phys) :: tmprb !temporary calculation for rb
real (kind=kind_phys) :: molg,fhgnew,cwpc
real (kind=kind_phys) :: mozgh, fhgnewh
! --------------------------------------------------------------------------------------------------
! stability correction to below canopy resistance

mozg = 0.
molg = 0.
mozgh = 0.

if(iter > 1) then
tmp1 = vkc * (grav/tah) * hg/(rhoair*cpair)
if (abs(tmp1) .le. mpe) tmp1 = mpe
molg = -1. * fv**3 / tmp1
mozg = min( (zpd-z0mg)/molg, 1.)
mozgh = min( (hcan - zpd)/molg, 1.)
end if

if (mozg < 0.) then
fhgnew = (1. - 15.*mozg)**(-0.25)
fhgnewh = 0.74 * (1. - 9.*mozg)**(-0.5) ! PHIh
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you remove this leading space so they line up?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done. Thanks.

else
fhgnew = 1.+ 4.7*mozg
fhgnewh = 0.74 + 4.7*mozgh ! PHIh
endif

if (iter == 1) then
fhg = fhgnew
fhgh = fhgnewh
else
fhg = 0.5 * (fhg+fhgnew)
fhgh = 0.5 * (fhgh+fhgnewh)
endif

cwpc = (cwp * vai * hcan * fhg)**0.5
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest we put in some limits like this: cwpc = max(min(cwpc,5.0),1.0)

Expand All @@ -4686,7 +4695,7 @@ subroutine ragrb(parameters,iter ,vai ,rhoair ,hg ,tah , & !in

! aerodynamic resistances raw and rah between heights zpd+z0h and z0hg.

kh = max ( vkc*fv*(hcan-zpd), mpe )
kh = max ( vkc*fv*(hcan-zpd)/(max(fhgh,0.1), mpe )
ramg = 0.
rahg = tmprah2 / kh
rawg = rahg
Expand Down
10 changes: 5 additions & 5 deletions physics/noahmp_tables.f90
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -510,11 +510,11 @@ module noahmp_tables

!
real :: cwpvt_table(mvt) !< empirical canopy wind parameter
data ( cwpvt_table (i),i=1,mvt) / 0.18, 0.67, 0.18, 0.67, 0.29, 1.00, &
& 2.00, 1.30, 1.00, 5.00, 1.17, 1.67, &
& 1.67, 1.67, 0.18, 0.18, 0.18, 0.67, &
& 1.00, 0.18, 0.00, 0.00, 0.00, 0.00, &
& 0.00, 0.00, 0.00, 0.00, 0.00, 0.00 /
data ( cwpvt_table (i),i=1,mvt) / 0.09, 0.335, 0.09, 0.335, 0.145, 0.50, &
& 1.00, 0.65, 0.50, 2.50, 0.585, 0.835, &
& 0.835, 0.835, 0.09, 0.09, 0.09, 0.335, &
& 0.835, 0.835, 0.09, 0.09, 0.09, 0.335, &
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be 0.5, 0.09, 0.00, 0.00, 0.00, 0.00?

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

line 516

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, Thank you!

& 0.00, 0.00, 0.00, 0.00, 0.00, 0.00 /


real :: wrrat_table(mvt) !< wood to non-wood ratio
Expand Down