-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
modify the eddy diffusivity for heat at the top of the canopy #21
modify the eddy diffusivity for heat at the top of the canopy #21
Conversation
@wzzheng90 do you plan additional commits for this PR? |
physics/module_sf_noahmplsm.f90
Outdated
end if | ||
|
||
if (mozg < 0.) then | ||
fhgnew = (1. - 15.*mozg)**(-0.25) | ||
fhgnewh = 0.74 * (1. - 9.*mozg)**(-0.5) ! PHIh |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you remove this leading space so they line up?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done. Thanks.
physics/module_sf_noahmplsm.f90
Outdated
@@ -4686,7 +4695,7 @@ subroutine ragrb(parameters,iter ,vai ,rhoair ,hg ,tah , & !in | |||
|
|||
! aerodynamic resistances raw and rah between heights zpd+z0h and z0hg. | |||
|
|||
kh = max ( vkc*fv*(hcan-zpd), mpe ) | |||
kh = max ( vkc*fv*(hcan-zpd)/fhgh, mpe ) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do we need protection against divide by zero here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I add max(fhgh,0.1) to avoid it. Thanks
I modified cwpvt LUT and modified "cd/lm" parameter (reduced half). |
physics/noahmp_tables.f90
Outdated
data ( cwpvt_table (i),i=1,mvt) / 0.09, 0.335, 0.09, 0.335, 0.145, 0.50, & | ||
& 1.00, 0.65, 0.50, 2.50, 0.585, 0.835, & | ||
& 0.835, 0.835, 0.09, 0.09, 0.09, 0.335, & | ||
& 0.835, 0.835, 0.09, 0.09, 0.09, 0.335, & |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should be 0.5, 0.09, 0.00, 0.00, 0.00, 0.00?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
line 516
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, Thank you!
@wzzheng90 As you mentioned, the model is very sensitive to the parameter cwpvt. With the latest change, the model didn't complete the case of 20120701. The other cases look fine. My run directory is /scratch1/NCEPDEV/stmp2/Helin.Wei/Prototype8.lsmz/COMROOT The job log file for the failed case is /scratch1/NCEPDEV/stmp2/Helin.Wei/Prototype8.lsmz/COMROOT/R_20120701/logs/2012070100/gfsfcst.log.0 Any suggestions? |
@HelinWei-NOAA It looks the model failed at "gfdl_cloud_microphys.F90". I had a similar problem about the MP failure when I changed others. Did you run the case with all land changes or just for this cwpvt modification? I did some tests and the model |
I ran with all Noah-MP changes.
|
else | ||
fhg = 0.5 * (fhg+fhgnew) | ||
fhgh = 0.5 * (fhgh+fhgnewh) | ||
endif | ||
|
||
cwpc = (cwp * vai * hcan * fhg)**0.5 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suggest we put in some limits like this: cwpc = max(min(cwpc,5.0),1.0)
With that limitation, the model went through that breaking point. The
subset results of this test can be
found /gpfs/dell3/ptmp/Helin.Wei/Prototype8.lsmf/COMROOT/P8lsmz.sub. The
verification page is https://www.emc.ncep.noaa.gov/mmb/gcp/gfs/p8alsmz. The
surface cape has been increased furthermore.
…On Tue, Mar 22, 2022 at 3:19 PM Michael Barlage ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In physics/module_sf_noahmplsm.f90
<#21 (comment)>
:
> else
fhg = 0.5 * (fhg+fhgnew)
+ fhgh = 0.5 * (fhgh+fhgnewh)
endif
cwpc = (cwp * vai * hcan * fhg)**0.5
I suggest we put in some limits like this: cwpc = max(min(cwpc,5.0),1.0)
—
Reply to this email directly, view it on GitHub
<#21 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ALPHKYAASK3C7OK75L2Y45TVBIMLFANCNFSM5RFXC6WA>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Sounds great! My test with P8a (case: 20120701) also went through, but without the limitation (cwpc = max(min(cwpc,5.0),1.0)). So, it seems that this modification together with other land changes would result in some other issues. |
@HelinWei-NOAA are you planning to put this change in the branch? I'm running the spin up now but just realized I am using the branch directly and haven't added this limit. |
Revised sensible heat flux for under-canopy sublayer in Noah-MP land surface model.
-- Modify the eddy diffusivity coefficients for momentum and heat at the top of the canopy.
-- Tune the parameters cd (the drag coefficient of leaves) and lm (mean mixing length).