Git update sometimes crashes after #585

[tobil4sk]

Occasionally when running haxelib update for a git repository (on Windows), there is a crash.

Crash logs

$ haxelib update hxcpp --debug
[debug] Using haxelib from "..."
# Running command: git [diff,--exit-code,--no-ext-diff]

# Exited with code 0

# Running command: git [diff,--cached,--exit-code,--no-ext-diff]

# Exited with code 0

# Running command: git [fetch]

# Exited with code 0

# Running command: git [rev-parse,@{u}]

3f6de84d4decb0a7aa1131ebd527f623b1e2d2b1

# Exited with code 0

# Running command: git [rev-parse,HEAD]

An exception occurred in a neko Thread :
std@lock_release
An exception occurred in a neko Thread :
std@lock_release
Called from ? line 1
Called from haxelib/Util.hx line 14
Called from haxelib/client/Main.hx line 895
Called from haxelib/Util.hx line 14
Called from haxelib/client/Main.hx line 268
Called from haxelib/client/Main.hx line 583
Called from haxelib/api/Installer.hx line 372
Called from haxelib/api/Installer.hx line 373
Called from haxelib/api/Installer.hx line 426
Called from haxelib/Util.hx line 14
Called from haxelib/api/Installer.hx line 826
Called from haxelib/api/Vcs.hx line 288
Called from haxelib/api/Vcs.hx line 167
Called from haxelib/api/Vcs.hx line 206
Called from C:\HaxeToolkit\haxe\std/neko/_std/sys/io/Process.hx line 108
Uncaught exception - std@process_exit

$ haxelib update hxcpp --debug
[debug] Using haxelib from "..."
# Running command: git [diff,--exit-code,--no-ext-diff]

# Exited with code 0

# Running command: git [diff,--cached,--exit-code,--no-ext-diff]

# Exited with code 0

# Running command: git [fetch]

# Exited with code 0

# Running command: git [rev-parse,@{u}]

3f6de84d4decb0a7aa1131ebd527f623b1e2d2b1

# Exited with code 0

# Running command: git [rev-parse,HEAD]

An exception occurred in a neko Thread :
std@lock_release
An exception occurred in a neko Thread :
std@lock_release
Called from ? line 1
Called from haxelib/Util.hx line 14
Called from haxelib/client/Main.hx line 895
Called from haxelib/Util.hx line 14
Called from haxelib/client/Main.hx line 268
Called from haxelib/client/Main.hx line 583
Called from haxelib/api/Installer.hx line 372
Called from haxelib/api/Installer.hx line 373
Called from haxelib/api/Installer.hx line 426
Called from haxelib/Util.hx line 14
Called from haxelib/api/Installer.hx line 826
Called from haxelib/api/Vcs.hx line 288
Called from haxelib/api/Vcs.hx line 167
Called from haxelib/api/Vcs.hx line 209
Called from C:\HaxeToolkit\haxe\std/neko/_std/sys/thread/Lock.hx line 34
Uncaught exception - std@lock_wait

$ haxelib update hxcpp --debug
[debug] Using haxelib from "..."
# Running command: git [diff,--exit-code,--no-ext-diff]

# Exited with code 0

# Running command: git [diff,--cached,--exit-code,--no-ext-diff]

# Exited with code 0

# Running command: git [fetch]

# Exited with code 0

# Running command: git [rev-parse,@{u}]

3f6de84d4decb0a7aa1131ebd527f623b1e2d2b1

# Exited with code 0

# Running command: git [rev-parse,HEAD]

Called from ? line 1
Called from haxelib/Util.hx line 14
Called from haxelib/client/Main.hx line 895
Called from haxelib/Util.hx line 14
Called from haxelib/client/Main.hx line 268
Called from haxelib/client/Main.hx line 583
Called from haxelib/api/Installer.hx line 372
Called from haxelib/api/Installer.hx line 373
Called from haxelib/api/Installer.hx line 426
Called from haxelib/Util.hx line 14
Called from haxelib/api/Installer.hx line 826
Called from haxelib/api/Vcs.hx line 288
Called from haxelib/api/Vcs.hx line 167
Called from haxelib/api/Vcs.hx line 206
Called from C:\HaxeToolkit\haxe\std/neko/_std/sys/io/Process.hx line 108
Uncaught exception - std@process_exit

Other times everything is fine:

haxelib update hxcpp --debug
[debug] Using haxelib from "..."
# Running command: git [diff,--exit-code,--no-ext-diff]

# Exited with code 0

# Running command: git [diff,--cached,--exit-code,--no-ext-diff]

# Exited with code 0

# Running command: git [fetch]

# Exited with code 0

# Running command: git [rev-parse,@{u}]

3f6de84d4decb0a7aa1131ebd527f623b1e2d2b1

# Exited with code 0

# Running command: git [rev-parse,HEAD]

3f6de84d4decb0a7aa1131ebd527f623b1e2d2b1

# Exited with code 0

Library hxcpp git repository is already up to date

Seems to only happen during the git rev-parse HEAD command. Does not seem to happen on 4.0.3, only on the development branch, which makes sense since 4.0.3 does not use git rev-parse HEAD.

[tobil4sk]

This may be related to HaxeFoundation/neko#281, since both started happening when the threads were added in #585.