Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

haxelib run + cwd behaviour #272

Open
nadako opened this issue Dec 22, 2015 · 3 comments
Open

haxelib run + cwd behaviour #272

nadako opened this issue Dec 22, 2015 · 3 comments
Assignees

Comments

@nadako
Copy link
Member

nadako commented Dec 22, 2015

The current behaviour is quite weird: We append cwd to the end of argument list and then change cwd to the library installation directory. What's the reason it's implemented like that? cc @ncannasse

I think it would be more correct not to change cwd and set the lib directory to the HAXELIB_RUN env var (currently it's always set to 1).

Changing this will break current haxelibs, so if we want to do it, we should think of some way to stay compatible.

@nadako
Copy link
Member Author

nadako commented Dec 22, 2015

Assigning to @ncannasse for comments :)

@ncannasse
Copy link
Member

I agree with the change. Not sure how to make sure to handle backward compatibility.

@nadako
Copy link
Member Author

nadako commented Dec 22, 2015

One possibility is to add some "haxelib protocol version" field to haxelib.json and use the new mechanism if it's set to proper value (and warn if author submits a library using old mechanism). But I'm not sure it's worth adding that field just for this change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants