Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Set to version" prompt does not unset dev #265

Open
jcward opened this issue Dec 19, 2015 · 3 comments
Open

"Set to version" prompt does not unset dev #265

jcward opened this issue Dec 19, 2015 · 3 comments
Labels

Comments

@jcward
Copy link

jcward commented Dec 19, 2015

Just ensuring hxcpp is up to date, I got the:

You already have hxcpp version 3.2.193 installed.
Set hxcpp to version 3.2.193 [y/n/a]? y
Library hxcpp current version is now 3.2.193

But when I checked haxelib list, it was still set to dev. I find this confusing.

I'd think the above prompt should unset dev. Or, if you don't want to change the behavior of the tool, perhaps the note should read:

Library hxcpp current version is now 3.2.193, but dev override is /home/jward/...

Also, I'm not sure if the git override works the same way?

@ibilon
Copy link
Member

ibilon commented Dec 19, 2015

Agree,
the message could also specify the current version.

Similar issue #106

By git override do you mean haxelib git?
If so it does make use of a dev set.
(could change #263)

@boozook
Copy link
Contributor

boozook commented Dec 22, 2015

Agree & try to explain..

  1. We don't need to remove .dev-file anyway in that use-case;
  2. Problem in the algorithm used in list command:
    • We have two files: .current & .dev;
    • Currently if .dev exists then .current will be ignored - it's wrong behaviour;
    • We need to prioritise .current over .dev.

@nadako
Copy link
Member

nadako commented Dec 22, 2015

I think the original purpose of dev is to override any currently installed versions, so prioritizing .current over .dev does not make sense IMO and the current behaviour is actually correct.

What we could do is what @jcward originally proposed: either prompt to unset dev or mention that dev mode is in effect.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants