Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Review extractor implementation #11127

Closed
Simn opened this issue Apr 12, 2023 · 0 comments · Fixed by #11141
Closed

Review extractor implementation #11127

Simn opened this issue Apr 12, 2023 · 0 comments · Fixed by #11141
Assignees
@Simn
Labels
feature-pattern-matching

Comments

@Simn
Copy link
Member

Simn commented Apr 12, 2023

While looking into #11062 I came across my extractor implementation, and quite frankly I have no idea wtf is going on there. It's not even a lot of code (less than 50 lines) and it has been working quite well, but it definitely needs some review and documentation in order to be maintainable.

One related issue is #5274 which required a bit of a workaround.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Simn Simn

Labels
feature-pattern-matching
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Rework extractors HaxeFoundation/haxe
1 participant
@Simn