Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Could you please to help me to make snake case path and value work? #36

Closed
sguryev opened this issue Oct 11, 2024 · 5 comments
Closed

Could you please to help me to make snake case path and value work? #36

sguryev opened this issue Oct 11, 2024 · 5 comments
Labels
bug Something isn't working

Comments

@sguryev
Copy link
Contributor

sguryev commented Oct 11, 2024 •
edited
Loading

I have added description to the PR. There is the test showing my problem.
@Havunen Havunen added the bug Something isn't working label Oct 18, 2024
@Havunen
Copy link
Owner

Havunen commented Oct 18, 2024

This will be fixed in the next release. It will be breaking change

@sguryev
Copy link
Contributor Author

sguryev commented Oct 18, 2024

@Havunen any workarounds we can use now? I think I can invent something but would like o know the best place to do it

@Havunen
Copy link
Owner

Havunen commented Oct 18, 2024

using JsonPropertyAttribute to decorate the snake_case property names everywhere you need it can be used as workaround, I will try to make a new release this weekend anyway

@sguryev
Copy link
Contributor Author

sguryev commented Oct 19, 2024 •
edited
Loading

Ouch, it looks too scary for our project :) I was thinking about some endpoint filter or middleware which can replace the body for PATCH requests. Anyway great news we can have new version this weekend. LMK if you need any help

@Havunen
Copy link
Owner

Havunen commented Oct 19, 2024

v4.0.0 has been released https://github.com/Havunen/SystemTextJsonPatch/releases/tag/v4.0.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Havunen @sguryev