Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Parameter 'xxx' is passed by value. It could be passed as a const reference which is usually faster and recommended in C++. #2379

Closed
marakew opened this issue Jun 14, 2022 · 0 comments · Fixed by #2558
Closed

Parameter 'xxx' is passed by value. It could be passed as a const reference which is usually faster and recommended in C++. #2379

marakew opened this issue Jun 14, 2022 · 0 comments · Fixed by #2558
Labels
[core] Area: Changes in SRT library core Type: Maintenance Work required to maintain or clean up the code
Milestone
v1.5.2

Comments

@marakew
Copy link

marakew commented Jun 14, 2022 •
edited
Loading

srt/srtcore/congctl.h

Line 56 in e8b713e

IsName(std::string nn): n(nn) {}

srt/srtcore/common.cpp

Line 460 in e8b713e

bool SrtParseConfig(string s, SrtConfig& w_config)

srt/srtcore/api.cpp

Line 4474 in e8b713e

void resetlogfa(set<LogFA> fas)

srt/srtcore/packetfilter.cpp

Line 29 in e8b713e

bool srt::ParseFilterConfig(string s, SrtFilterConfig& w_config, PacketFilter::Factory** ppf)

srt/srtcore/packetfilter.cpp

Line 46 in e8b713e

bool srt::ParseFilterConfig(string s, SrtFilterConfig& w_config)

@marakew marakew changed the title Parameter 'nn' is passed by value. It could be passed as a const reference which is usually faster and recommended in C++. Parameter 'xxx' is passed by value. It could be passed as a const reference which is usually faster and recommended in C++. Jun 14, 2022
@maxsharabayko maxsharabayko added this to the Next Release milestone Jun 15, 2022
@maxsharabayko maxsharabayko modified the milestones: v1.5.1, Next release Sep 12, 2022
@maxsharabayko maxsharabayko added Type: Maintenance Work required to maintain or clean up the code [core] Area: Changes in SRT library core labels Nov 28, 2022
@maxsharabayko maxsharabayko mentioned this issue Nov 28, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
[core] Area: Changes in SRT library core Type: Maintenance Work required to maintain or clean up the code
Projects
None yet
Milestone
v1.5.2
Development

Successfully merging a pull request may close this issue.

[core] Pass std::string by const ref where possible. maxsharabayko/srt
2 participants
@marakew @maxsharabayko