Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[API] Deprecate srt_rejectreason_msg array #2285

Closed
maxsharabayko opened this issue Apr 11, 2022 · 0 comments · Fixed by #2312
Closed

[API] Deprecate srt_rejectreason_msg array #2285

maxsharabayko opened this issue Apr 11, 2022 · 0 comments · Fixed by #2312
Labels
[API] Area: Changes in SRT library API Type: Maintenance Work required to maintain or clean up the code
Milestone
v1.5.0

Comments

@maxsharabayko
Copy link
Collaborator

The array srt_rejectreason_msg is present in the SRT API (added in v1.3.4 in PR #720).
It is quite unsafe because someone may access it out of bounds by mistake.
The API function srt_rejectreason_str() should be used instead.

The array srt_rejectreason_msg should be marked as deprecated.
@maxsharabayko maxsharabayko added Type: Maintenance Work required to maintain or clean up the code [API] Area: Changes in SRT library API labels Apr 11, 2022
@maxsharabayko maxsharabayko added this to the v1.4.5 milestone Apr 11, 2022
@maxsharabayko maxsharabayko mentioned this issue Apr 25, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
[API] Area: Changes in SRT library API Type: Maintenance Work required to maintain or clean up the code
Projects
None yet
Milestone
v1.5.0
Development

Successfully merging a pull request may close this issue.

[API] Deprecated srt_rejectreason_msg[]. maxsharabayko/srt
1 participant
@maxsharabayko