Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Racy load() when ATOMIC_USE_MSVC_INTRINSICS is used #2108

Open
maxsharabayko opened this issue Aug 30, 2021 · 0 comments
Open

[BUG] Racy load() when ATOMIC_USE_MSVC_INTRINSICS is used #2108

maxsharabayko opened this issue Aug 30, 2021 · 0 comments
Labels
[core] Area: Changes in SRT library core Priority: Low Type: Bug Indicates an unexpected problem or unintended behavior
Milestone
Parking Lot

Comments

@maxsharabayko
Copy link
Collaborator

maxsharabayko commented Aug 30, 2021 •
edited
Loading

As reported by @jlsantiago0 in PR #2104, load() for ATOMIC_USE_MSVC_INTRINSICS is racy and should be fixed.

Generally, C++11 and hence the corresponding std::atomic library is recommended to be used on Windows by defining -DENABLE_STDCXX_SYNC=ON. With such configuration usage of a pthreads port is also avoided. And also this issue is not in force for such a build configuration.

However, let this issue be here until fixed or build configuration -DENABLE_STDCXX_SYNC=OFF is completely forbidden on Windows.

Affected versions: SRT v1.4.4 and above.
Note. Support for atomic was added in SRT v1.4.4.
@maxsharabayko maxsharabayko added Priority: Low Type: Bug Indicates an unexpected problem or unintended behavior [core] Area: Changes in SRT library core labels Aug 30, 2021
@maxsharabayko maxsharabayko added this to the Parking Lot milestone Aug 30, 2021
@maxsharabayko maxsharabayko mentioned this issue Aug 30, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
[core] Area: Changes in SRT library core Priority: Low Type: Bug Indicates an unexpected problem or unintended behavior
Projects
None yet
Milestone
Parking Lot
Development

No branches or pull requests
1 participant
@maxsharabayko