Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the Twig metadata #11

Merged
merged 2 commits into from
Apr 6, 2017
Merged

Update the Twig metadata #11

merged 2 commits into from
Apr 6, 2017

Conversation

stof
Copy link
Contributor

@stof stof commented Nov 30, 2016

No description provided.

@Koc
Copy link
Contributor

Koc commented Nov 30, 2016

@stof can you also add support of new methods like getRuntime? And reflect changes in getExtension (now it accepts also class name).

@stof
Copy link
Contributor Author

stof commented Nov 30, 2016

@Koc I'm not sure what would be provided for getRuntime. Any class name ?

Regarding getExtension, can we provide multiple sources for a provider @Haehnchen ? We would need both the names (existing return provider) and subclass names.

@Koc
Copy link
Contributor

Koc commented Nov 30, 2016

I'm not sure what would be provided for getRuntime. Any class name ?

As I understand - yes. And this method returns the same type of passed class. $twig->getRuntime('Foo') // returns \Foo.

@King2500
Copy link
Contributor

What happened to Twig_TemplateInterface? Is that deprecated/removed from Twig?

@Koc
Copy link
Contributor

Koc commented Mar 10, 2017

@stof
Copy link
Contributor Author

stof commented Mar 10, 2017

@King2500 using a totally custom implementation of the interface was never well supported (and Twig_Template has always been considered an internal API). This is why the interface was dropped.

@stof
Copy link
Contributor Author

stof commented Apr 6, 2017

@Haehnchen any news ?

@King2500
Copy link
Contributor

King2500 commented Apr 6, 2017

I think it's good to merge 👍

@Haehnchen Haehnchen merged commit c4d622c into Haehnchen:master Apr 6, 2017
@stof stof deleted the twig branch April 6, 2017 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants