Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Submodule missing from source tarball #209

Closed
nikoladze opened this issue Nov 19, 2021 · 2 comments · Fixed by #214
Closed

Submodule missing from source tarball #209

nikoladze opened this issue Nov 19, 2021 · 2 comments · Fixed by #214
Assignees

Comments

@nikoladze
Copy link

The spdlog submodule is missing from the source tarball (https://github.com/HSF/prmon/archive/refs/tags/v3.0.0.tar.gz). Noticed this since i use the source tarball for an AUR package of prmon. There are workarounds (i could directly clone the git or manually fetch the submodule or use the binary package), but maybe there is a way to include the submodule in the source tarball.

@graeme-a-stewart graeme-a-stewart self-assigned this Dec 14, 2021
@graeme-a-stewart
Copy link
Member

Hello @nikoladze - apologies for the very late reply on this. I somehow missed that you raised this ticket. Let's see what we can do, the tarball is prepared by cmake so it should be possible to ensure that it includes spdlog as well.

@graeme-a-stewart
Copy link
Member

Actually the source tarball is prepared by github itself (cmake only does the static build binary tarball). We need to investigate workarounds.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants