Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added option to skip parsing of results #35

Merged
merged 7 commits into from
May 27, 2022
Merged

Added option to skip parsing of results #35

merged 7 commits into from
May 27, 2022

Conversation

forest
Copy link
Collaborator

@forest forest commented May 26, 2022

No description provided.

@forest forest requested review from aschreifels and sarahdasko May 26, 2022 06:30
Copy link
Contributor

@sarahdasko sarahdasko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great

i know update and delete would be duplicates of insert but if we're defining one, should we create all? or have a singular more generic on called ddl_dml?

@forest
Copy link
Collaborator Author

forest commented May 26, 2022

I thought about update and delete too. Maybe it is best to mimic the Ecto.Repo query and schema apis. https://hexdocs.pm/ecto/Ecto.Repo.html#query-api

Those higher-level functions provide some guidance, but user can always drop down to query to keep full control.

@forest
Copy link
Collaborator Author

forest commented May 26, 2022

Maybe it is actually best to keep the API as is. Just query and document when to use the parse_results option. I think that is best.

Copy link
Contributor

@sarahdasko sarahdasko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i like it, super simple and allows for us to not pay the transaction and parsing cost

@forest forest merged commit 4cf42ee into main May 27, 2022
@forest forest deleted the insert-no-parse branch May 27, 2022 02:28
hgdeploy pushed a commit that referenced this pull request May 27, 2022
# [0.7.0](v0.6.4...v0.7.0) (2022-05-27)

### Chores

* **docs:** update readme with badges (#34) ([88f4351](88f4351)), closes [#34](#34)

### Features

* added option to skip parsing of results (#35) ([4cf42ee](4cf42ee)), closes [#35](#35)
@hgdeploy
Copy link

🎉 This PR is included in version 0.7.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants