Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature Request (Submitted by 3723) - Add IIHF awards information under player awards #217

Open
GuthrieW opened this issue Nov 1, 2024 · 2 comments
Open

Feature Request (Submitted by 3723) - Add IIHF awards information under player awards #217

GuthrieW opened this issue Nov 1, 2024 · 2 comments
Assignees
@GuthrieW
Labels
Low Priority story A new feature to be added to the application

Comments

@GuthrieW
Copy link
Owner

GuthrieW commented Nov 1, 2024

Description

Show IIHF awards under player awards too, not just SHL awards. We have IIHF cards for them after all.

Desired Functionality

Add the IIHF awards a player has won (the portal has the data) here where the player awards are displayed. https://imgur.com/a/isVZGyK Since we don't show the IIHF award season on the card, because some players won multiple of them, at least it can be looked up here which season the award was for. Right now that info is only in the portal.
@GuthrieW GuthrieW added the story A new feature to be added to the application label Nov 1, 2024
@GuthrieW GuthrieW self-assigned this Nov 1, 2024
@luketd
Copy link
Collaborator

luketd commented Nov 1, 2024

its hard because the ID's that are given are SHL id's only. so they dont map to IIHF awards

@GuthrieW
Copy link
Owner Author

This is not currently simple enough to be prioritized.

@GuthrieW GuthrieW changed the title Feature Request (Submitted by 3723) Feature Request (Submitted by 3723) - Add IIHF awards information under player awards Dec 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@GuthrieW GuthrieW

Labels
Low Priority story A new feature to be added to the application
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@GuthrieW @luketd