Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Expose Windows user SID #790

Closed
MarkRx opened this issue Jul 6, 2022 · 1 comment
Closed

[Feature Request] Expose Windows user SID #790

MarkRx opened this issue Jul 6, 2022 · 1 comment
Labels

Comments

@MarkRx
Copy link
Contributor

MarkRx commented Jul 6, 2022

A windows SID is somewhat analogous to a *nix UID.

The data is already available in this method. It can be converted to a string using ConvertSidToStringSidW then stored in the process struct.

This would be a windows only function/value. It could be handled by having OS specific traits (WindowsProcessExt, LinuxProcessExt, etc) to enhance the process struct based on context or by having a fake method on every trait impl.

@GuillaumeGomez
Copy link
Owner

Normally, Uid would already allow you to have access to this information. The problem here is that the SID of the process and the SID of the user don't match. So I decided to use the user name as Uid instead, meaning that I even though I manipulate this information at some point, I don't store it. So until the SID mismatch bug is fixed, you won't be able to have access to this information from sysinfo.

Closing then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants