Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor ExecutingInvocationUnit to use customizable executors #126

Merged
merged 11 commits into from
Feb 15, 2024

Conversation

kilzm
Copy link
Contributor

@kilzm kilzm commented Feb 12, 2024

This refactors the old ExecutingInvocationUnit and sensibly separates its responsibilities into other classes.
It now maintains a configurable list of executors, each of which provides a way to obtain the result of a method within a range of supported methods.
A major advantage of this approach is that executors can handle a method however they want, e.g., avoiding reflection.

The old behavior is kept as a default, meaning a StringReflectionExecutor will be added unless explicitly disabled.

Aside from simplifying major parts of the logic, some improvements to the functionality have been made:

  • Support all types of 1D arrays as parameters including arrays of references when using reflection (added tests for String.join() and String.format()).
  • An equals check in ExecutingInvocationUnit makes sure that the instance of the method in stack and variables will always be updated if it changed.

docs/md/releasenotes.md Outdated Show resolved Hide resolved
docs/md/partialevaluator.md Outdated Show resolved Hide resolved
@capoz
Copy link
Contributor

capoz commented Feb 15, 2024

Looks good to me, I would just add a changelog entry for stuff you have fixed and other functional changes (e.g., the value analysis fix for category 2 values, the array support to handle String.format and similar methods)

@capoz capoz merged commit 7ea70f5 into Guardsquare:master Feb 15, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants