Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing translations (en); and enforce coverage. #3184

Open
wants to merge 33 commits into
base: dev
Choose a base branch
from

Conversation

CloCkWeRX
Copy link
Collaborator

@CloCkWeRX CloCkWeRX commented Dec 9, 2022

Fixes #2745

  • TBA - should we only run the unit tests on en locales? I can't translate to japanese easily
  • Alternatively, are we okay with auto translations

I took out the japanese translation, as it was 1x string.

Very annoying, I can either define the pluralisation of our models, or I can appease i18n-tasks.

  • Make i18n-tasks happy with activerecord entries
  • Fix specs.

@CloCkWeRX CloCkWeRX changed the title Issue/2745 translations Add missing translations (en); and enforce coverage. Dec 9, 2022
config/locales/en.yml Outdated Show resolved Hide resolved
config/locales/en.yml Outdated Show resolved Hide resolved
config/locales/en.yml Outdated Show resolved Hide resolved
config/locales/en.yml Outdated Show resolved Hide resolved
@CloCkWeRX CloCkWeRX requested a review from cesy December 9, 2022 23:47
app/views/layouts/_menu.haml Outdated Show resolved Hide resolved
app/views/layouts/_menu.haml Outdated Show resolved Hide resolved
app/views/layouts/_menu.haml Show resolved Hide resolved
app/views/layouts/_menu.haml Show resolved Hide resolved
app/views/layouts/_menu.haml Show resolved Hide resolved
app/views/layouts/_menu.haml Show resolved Hide resolved
app/views/layouts/_menu.haml Show resolved Hide resolved
Copy link
Member

@cesy cesy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me so far, lots of unused strings there which is a pity, but it's the right thing to clean them up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Translations missing: Menu
3 participants