You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Most times, callers ensure that the pushed value ref has a valid data type. But they still need to add a safety note in the comment and unwrap the result manually.
Consider refactoring the MutableVector and changing the push_value_ref() to panic by default (with panic section in doc comments). We could rename the old push_value_ref() method to try_push_value_ref().
Now using
MutableVector::push_value_ref
is verbose as callers always need to handle the returnedResult
.greptimedb/src/datatypes/src/vectors.rs
Line 178 in be897ef
Most times, callers ensure that the pushed value ref has a valid data type. But they still need to add a safety note in the comment and unwrap the result manually.
greptimedb/src/datatypes/src/schema/column_schema.rs
Lines 148 to 149 in be897ef
Consider refactoring the
MutableVector
and changing thepush_value_ref()
to panic by default (withpanic
section in doc comments). We could rename the oldpush_value_ref()
method totry_push_value_ref()
.We could also add a
push_null
method to make pushing null more convenientgreptimedb/src/common/grpc-expr/src/insert.rs
Lines 99 to 101 in be897ef
The text was updated successfully, but these errors were encountered: