Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Crash] On server host closing server led to a crash. #2828

Open
2 tasks done
Cosmoros-git opened this issue Feb 5, 2025 · 5 comments · May be fixed by #2829
Open
2 tasks done

[Crash] On server host closing server led to a crash. #2828

Cosmoros-git opened this issue Feb 5, 2025 · 5 comments · May be fixed by #2829
Assignees
Labels
type: bug Something isn't working

Comments

@Cosmoros-git
Copy link

Checked for existing issues

  • I have checked for existing issues, and have found none.

Tested latest version

  • I have checked that this occurs on the latest version.

GregTech CEu Version

1.6.3

Minecraft Version

1.20.1 Forge

Recipe Viewer Installed

EMI

Environment

Multiplayer - Open to LAN

Cross-Mod Interaction

Yes

Other Installed Mods

Star Technology modpack.

Expected Behavior

Not crash.

Actual Behavior

Crash

Steps to Reproduce

Join server.
Server shuts down.
Got to the menu and tried leaving.
Crashed.

Additional Information

crash-2025-02-05_12.45.48-client.txt

Crashlog blamed This mod and ldlib

@Cosmoros-git Cosmoros-git added the type: bug Something isn't working label Feb 5, 2025
@omergunr100
Copy link
Contributor

I'm not sure this is fixable, we listen for keybinds and transmits them to the server to do stuff, when the server owner closed the world the channel to the server was probably closed mid-transmission, so the packet handler threw a NPE.

Not much we can do about it apart from not using keybinds.

@Cosmoros-git
Copy link
Author

I'm not sure this is fixable, we listen for keybinds and transmits them to the server to do stuff, when the server owner closed the world the channel to the server was probably closed mid-transmission, so the packet handler threw a NPE.

Not much we can do about it apart from not using keybinds.

Adding a handle in a situation where the response is invalid so the game doesn't crash should at least fix the crashing issue.

@omergunr100
Copy link
Contributor

We could surround the specific command that sends keybinds to the server with a try-catch for NullPointerExceptions even though it's not a best practice and just log it, the client shouldn't care much if a keybind didn't transmit properly because the server closed.

@omergunr100
Copy link
Contributor

btw, does it crash you to the desktop or just pops a message on the screen?

@Cosmoros-git
Copy link
Author

btw, does it crash you to the desktop or just pops a message on the screen?

I got kicked out of the server and pressed the "menu" button. Or however, it's called– and the game fully crashed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Something isn't working
Projects
None yet
2 participants