-
Notifications
You must be signed in to change notification settings - Fork 199
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Crash] On server host closing server led to a crash. #2828
Comments
I'm not sure this is fixable, we listen for keybinds and transmits them to the server to do stuff, when the server owner closed the world the channel to the server was probably closed mid-transmission, so the packet handler threw a NPE. Not much we can do about it apart from not using keybinds. |
Adding a handle in a situation where the response is invalid so the game doesn't crash should at least fix the crashing issue. |
We could surround the specific command that sends keybinds to the server with a try-catch for |
btw, does it crash you to the desktop or just pops a message on the screen? |
I got kicked out of the server and pressed the "menu" button. Or however, it's called– and the game fully crashed. |
Checked for existing issues
Tested latest version
GregTech CEu Version
1.6.3
Minecraft Version
1.20.1 Forge
Recipe Viewer Installed
EMI
Environment
Multiplayer - Open to LAN
Cross-Mod Interaction
Yes
Other Installed Mods
Star Technology modpack.
Expected Behavior
Not crash.
Actual Behavior
Crash
Steps to Reproduce
Join server.
Server shuts down.
Got to the menu and tried leaving.
Crashed.
Additional Information
crash-2025-02-05_12.45.48-client.txt
Crashlog blamed This mod and ldlib
The text was updated successfully, but these errors were encountered: