-
Notifications
You must be signed in to change notification settings - Fork 141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Jeff Vierstra's Non-redundant TF motifs? #214
Comments
I agree that this would be useful. Lets see what @jgranja24 says. |
I can add an option for custom pwms as input. Best jeff |
Sorry for the late update on this --- you can add these motifs with the following code
|
I got an error message when I try to run the code (i just installed the updated ArchR): Warning message in gzfile(file, "rb"):
|
did you download the motifs? |
the error appears after I run |
You need the motif file - wget https://jeffgranja.s3.amazonaws.com/ArchR/Annotations/Vierstra-Human-Motifs.rds You can check this |
Turns out it wasnt a public downloadable link please try again!
|
it worked now! Thanks! |
@jgranja24 Hello Jeff, I saw that there is V-human-motifs, Could I ask if there is potentially mouse motif version? I saw there is mouse version in Vierstra website. Thank you! |
Hi @willey2020, Im pretty sure that the one i made is both. Sorry for the confusion! |
@jgranja24 Ah Thank you so much Jeff!! That is great news!! |
Describe the problem that your feature request would address.
Jeff Vierstra has generated a nice resource for clustered motif models and motif "Archetypes" here: https://www.vierstra.org/resources/motif_clustering
It would be great to be able to use these motif archetypes for motif enrichment analyses to avoid getting many hits for nearly-identical motifs in motif databases.
Describe the solution you'd like
I would like to be able to use these (or similar) clustered motif archetypes as an option for motifSet in addMotifAnnotations.
Describe alternatives you've considered
I could split up the BED files provided at the URL, above, per motif archtype, and compute enrichment using addPeakAnnotations and peakAnnoEnrichment as you describe here: https://www.archrproject.com/bookdown/custom-enrichment.html
However, this would be a different approach to enrichment from what's available for the JASPAR and chromVar databases using motifmatchr.
Alternately, allowing a user-supplied set of PWMs for addMotifAnnotations (addCustomMotifAnnotations?) that passes motifs into the motifmatchr step may be workable without building too much more into the package.
Additional context
If what's needed for this to work is packaging of these motif archetypes into a TFBSTools-compatible PWM package, I may be able to do that legwork. Before I do so, it would be great to get some feedback as to the best approach for use in ArchR.
Thanks again for this package! I've been building trajectories over the last couple of days, and it's been going great.
Cheers,
-Lucas
The text was updated successfully, but these errors were encountered: