Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dashes in role names are not allowed by ansible #178

Closed
reduzent opened this issue Sep 13, 2021 · 3 comments
Closed

dashes in role names are not allowed by ansible #178

reduzent opened this issue Sep 13, 2021 · 3 comments

Comments

@reduzent
Copy link

According to https://galaxy.ansible.com/docs/contributing/creating_role.html#role-names --characters should not be used in ansible roles. I understand that it was common to prefix role names with andible-role- in Galaxy. Thus, the documentation suggests to add an extra field to meta/main.yml:

galaxy_info:
  role_name: graylog
@malcyon
Copy link
Contributor

malcyon commented Sep 29, 2021

Leaving this open until I get time to release it and make sure it's right.

@malcyon malcyon reopened this Sep 29, 2021
@malcyon
Copy link
Contributor

malcyon commented Sep 30, 2021

Okay, I cut a new release with this change. We are now located at:

https://galaxy.ansible.com/Graylog2/graylog

I hate that the old url (https://galaxy.ansible.com/Graylog2/graylog-ansible-role) is now a dead link. Not even a redirect! This will break anyone trying to pull the role using the old name.

BUT, I upgraded Ansible on my machine yesterday and it was giving me errors because of the dashes in the name. Applying this fix was the only thing that would let me run it.

It seems like the naming standards changed out from under us over the years. I hate breaking changes, but hopefully this is defensible.

@malcyon malcyon closed this as completed Sep 30, 2021
@dragona-Ocient
Copy link

We don't use the galaxy role, this was our own role.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants